Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Synopsis/Xilinx Design Constraints Language Config Filename #241

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

MasonEdgar
Copy link
Contributor

@MasonEdgar MasonEdgar commented Sep 17, 2024

The SDC/XDC language configuration path in package.json does not match the filename in the ./configs folder. This breaks certain features like being able to toggle comments on/off, etc. Fixing the filename resolves the issue.

Added VHDL syntax highlighting

Added the let keyword to the syntax file.

@joecrop
Copy link
Collaborator

joecrop commented Oct 23, 2024

@MasonEdgar do you have permission from 'Brian Padalino' to copy his vhdl syntax work into this library? Can you point me to the original license?

@MasonEdgar
Copy link
Contributor Author

@joecrop The VHDL files are from vscode-verilog-hdl-support, which has an MIT license.

Feel free to remove the VHDL files if there's any license concerns

@joecrop
Copy link
Collaborator

joecrop commented Oct 24, 2024

License looks good. I'll merge it in. Thanks

@joecrop joecrop merged commit 8506d10 into eirikpre:master Oct 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants