Implement as a JsonSchemaExporter shim for STJv9
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 6, 2024
github-merge-queue bot
pushed a commit
to microsoft/semantic-kernel
that referenced
this pull request
Sep 2, 2024
Updates `JsonSchemaMapper` to include the changes from eiriktsarpalis/stj-schema-mapper#5. The changes reimplement the component as a shim over the built-in schema exporter available in System.Text.Json v9, for targets that support it. This should give SK built-in schema generation for free simply by upgrading its dependencies to STJ version 9.0.x once generally available. cc @stephentoub @markwallace-microsoft --------- Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JsonSchemaExporterclass that is built into System.Text.Json v9 and above.JsonSchemaExporter.cc @stephentoub @NTaylorMullen @markwallace-microsoft