Supports Alpine by detecting OS using /etc/alpine-release #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This obviates #853 via a slightly different approach * Move the default download root to the `Platform` impl * Allow a classifier (currently only musl, but there are others) * Special case Alpine instead of generically The above changes allow someone to override the download root regardless of if the nodejs dist is experimental or not. Finally, this backfills tests for `Platform` using the same approach as we do in Brave (powermock).
codefromthecrypt
pushed a commit
to openzipkin/zipkin
that referenced
this pull request
Oct 3, 2020
|
testing manually here (our builder image is alpine) https://github.com/openzipkin/zipkin/compare/DO_NOT_MERGE_test-frontend-maven-plugin |
|
^^ works fine! |
|
OK, let's go with this implementation! |
|
There we go, it's in the 1.10.2 release. |
|
Thanks for the quick turnaround, @eirslett! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Alpine is a small OS distribution that supports JDK. Supporting Alpine
means less download time and cost when building projects in Docker.
This solves the same problem #853 did, via a different approach.
PlatformimplThe above changes allow someone to override the download root regardless
of if the nodejs dist is experimental or not.
Tests and Documentation
This backfills tests for
Platformusing the same approach as we do in Brave(powermock).