Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix set_level side effects #61

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

chekunkov
Copy link

On test case completion all modifications to loggers levels are reversed.

Fixes #60

On test case completion all modifications to loggers levels are reversed.
@chekunkov
Copy link
Author

Have no idea why pypy3 tests fail, they are broken in master.

Regards 2.6 tests failure - I have two options:

  1. Have if statement with some fix only for Py 2.6.
  2. Drop .Py 2.6 support.

I'd go with the latter option, it seems to be trending among major Python packages:

pypa/pip#3955
pypa/setuptools#878
pytest-dev/pytest#2031

WDYT?

@hugovk
Copy link

hugovk commented Oct 2, 2017

@hugovk
Copy link

hugovk commented Nov 20, 2017

Here's the pip installs for pytest-catchlog from PyPI for the last month (via pypinfo --percent --pip pytest-catchlog pyversion)

python_version percent download_count
2.7 57.1% 25,939
3.6 18.4% 8,337
3.5 14.4% 6,535
3.4 6.6% 3,014
3.3 2.6% 1,194
3.7 0.8% 363
2.6 0.1% 25

I think it's safe to drop 2.6!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants