-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt type use based on class bound #1032
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
framework/src/main/java/org/checkerframework/common/basetype/BaseTypeVisitor.java
Outdated
Show resolved
Hide resolved
@@ -15,9 +15,27 @@ | |||
this.f = new @ReceiverDependentQual Object(); | |||
} | |||
|
|||
// This method could be called by both @A and @B instances. | |||
void recieverDependentMethod(@ReceiverDependentQual TestGetAnnotatedLhs this) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the test for testing the new change.
To summarize this PR:
This help us eliminate many errors message. |
I think the misc check sometimes fails but not always with the following error message:
|
result.addAll( | ||
((AbstractViewpointAdapter) viewpointAdapter) | ||
.combineAnnotationWithType(anno, useType) | ||
.getAnnotations()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why adapting anno with useType, should it be useType adapt anno?
AnnotationMirrorSet result = new AnnotationMirrorSet(); | ||
for (AnnotationMirror anno : getTypeDeclarationBounds(type)) { | ||
result.addAll( | ||
((AbstractViewpointAdapter) viewpointAdapter) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expose method in the interface and remove this downcast.
No description provided.