Set -Anomsgtext by default for all tests #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcai1
commented
Apr 6, 2022
framework-test/src/main/java/org/checkerframework/framework/test/TypecheckExecutor.java
Show resolved
Hide resolved
zcai1
commented
Apr 6, 2022
framework-test/src/main/java/org/checkerframework/framework/test/TypecheckResult.java
Show resolved
Hide resolved
wmdietl
reviewed
Apr 6, 2022
framework-test/src/main/java/org/checkerframework/framework/test/TypecheckResult.java
Show resolved
Hide resolved
wmdietl
reviewed
Apr 8, 2022
framework-test/src/main/java/org/checkerframework/framework/test/TypecheckResult.java
Outdated
Show resolved
Hide resolved
framework-test/src/main/java/org/checkerframework/framework/test/TypecheckExecutor.java
Outdated
Show resolved
Hide resolved
wmdietl
reviewed
Apr 10, 2022
| @@ -137,7 +137,6 @@ protected CheckerFrameworkPerDirectoryTest( | |||
| this.testDir = "tests" + File.separator + testDir; | |||
| this.classpathExtra = classpathExtra; | |||
| this.checkerOptions = new ArrayList<>(Arrays.asList(checkerOptions)); | |||
There was a problem hiding this comment.
Suggested change
| this.checkerOptions = new ArrayList<>(Arrays.asList(checkerOptions)); | |
| this.checkerOptions = Arrays.asList(checkerOptions); |
There was a problem hiding this comment.
Can you try whether this works? Now that this doesn't add anything to the list, wrapping in a new ArrayList shouldn't be necessary.
Co-authored-by: Werner Dietl <wdietl@gmail.com>
AndrewShf
pushed a commit
to AndrewShf/checker-framework
that referenced
this pull request
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.