forked from typetools/checker-framework
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce @TargetLocations
meta-annotation
#339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wmdietl
changed the title
enforce meta annotation TargetLocations
Enforce TargetLocations meta-annotation
Nov 15, 2022
AndrewShf
commented
Nov 15, 2022
framework/src/main/java/org/checkerframework/common/basetype/BaseTypeValidator.java
Show resolved
Hide resolved
AndrewShf
commented
Nov 15, 2022
framework/src/main/java/org/checkerframework/common/basetype/BaseTypeVisitor.java
Outdated
Show resolved
Hide resolved
AndrewShf
commented
Nov 15, 2022
framework/src/main/java/org/checkerframework/common/basetype/BaseTypeVisitor.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Werner Dietl <wdietl@gmail.com>
Co-authored-by: Werner Dietl <wdietl@gmail.com>
…getlocation meta-annotation running certain test suites
wmdietl
reviewed
Oct 1, 2023
framework/src/main/java/org/checkerframework/common/basetype/BaseTypeValidator.java
Outdated
Show resolved
Hide resolved
wmdietl
reviewed
Oct 1, 2023
framework/src/main/java/org/checkerframework/common/basetype/BaseTypeVisitor.java
Outdated
Show resolved
Hide resolved
wmdietl
approved these changes
Oct 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this hard issue!
I left one javadoc improvement comment, please fix that in a separate PR.
framework/src/main/java/org/checkerframework/common/basetype/BaseTypeVisitor.java
Show resolved
Hide resolved
framework/src/main/java/org/checkerframework/common/basetype/BaseTypeVisitor.java
Outdated
Show resolved
Hide resolved
wmdietl
reviewed
Oct 1, 2023
framework/src/main/java/org/checkerframework/common/basetype/BaseTypeVisitor.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce meta annotation @TargetLocations. Validate locations listed in file
TypeUseLocation.java
This PR is related to #349 (optionally warn about redundant annotations).
This PR aims at forbidding certain qualifiers from being applied to the program ("apply" means that the qualifier cannot be written in the source code explicitly nor be inferred to be placed in the code implicitly). The other PR warns about explicitly written qualifiers in the code if they are the same as the default qualifiers would be applied.
Correponding changes in other repos:
Universe: https://github.com/opprop/universe/pull/59/files
CFI: opprop/checker-framework-inference#413