Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to .gitignore #568

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Updates to .gitignore #568

merged 3 commits into from
Sep 25, 2023

Conversation

Ao-senXiong
Copy link
Member

There is a same entry in line 36.

wmdietl
wmdietl requested changes Sep 19, 2023
View reviewed changes
Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do a few further cleanups in this PR.
Lines 29/30 don't seem necessary. ant isn't used anywhere, right?

Directory checker/jdk also isn't used anymore, so those should be cleaned up.

Is there ever a stubparser/docs/api directory?

.gitignore
@@ -96,7 +96,6 @@ docs/manual/figures/*.pdf
docs/manual/figures/*.png
docs/manual/figures/signature-types-with-canonicalname.dia
docs/manual/manual.html-e
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nicer to have this here, together with the other docs ignores.
How about also moving the other docs entries, from line 107, here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already group them together.

@Ao-senXiong
Copy link
Member Author

Let's do a few further cleanups in this PR. Lines 29/30 don't seem necessary. ant isn't used anywhere, right?

Directory checker/jdk also isn't used anymore, so those should be cleaned up.

Is there ever a stubparser/docs/api directory?

I deleted them in the latest commit. Thanks.

wmdietl
wmdietl reviewed Sep 25, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
wmdietl
wmdietl approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wmdietl wmdietl changed the title Remove duplicate docs/tmpapi/ entry Updates to .gitignore Sep 25, 2023
@wmdietl wmdietl merged commit 8369e59 into eisop:master Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmdietl wmdietl wmdietl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ao-senXiong @wmdietl