Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typetools/checker-framework 3.38.0 release #600

Merged
merged 35 commits into from
Oct 16, 2023

Conversation

wmdietl
Copy link
Member

@wmdietl wmdietl commented Oct 16, 2023

No description provided.

wmdietl and others added 30 commits October 16, 2023 08:03
* Update versions.errorprone to v2.21.0

* Update versions.errorprone to v2.21.0

* Suppress warning.

* Add comment.

* Tweak comment.

* Fix bug.

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This change includes multiple adjustments:

- Instead of adding `com.google.errorprone:javac` as a dependency, copy
it to the output folder. This is important to ensure that your project
does not accidentally import and use any of the classes in that jar. It
will also reduce the size of your project's dependency tree.
Furthermore, this is only relevant in the JDK 8 profile.

  - Removed unused property `errorProneJavac`.

  - Removed (now-)unused use of `maven-dependency-plugin:properties`.

  - Converted deprecated `<compilerArguments>` to `<compilerArgs>`.

- Removed explicit dependency on `org.checkerframework:checker`, which
is not necessary because it is also present in the
`<annotationProcessorPaths>` block. This will also reduce the size of
your project's dependency tree (you probably only need the classes in
`checker-qual`).

- Removed unnecessary `<fork>true</fork>` declarations; these are
inherited.

- Moved animal-sniffer configuration to its own section. I don't think
we should recommend a blanket disable; people might copy-paste the
configuration without realizing they are disabling a useful plugin.

- Added single-quotes in the `-P '!checkerframework'` flags. The bang
character has special meaning in most shells (including Bash), and the
quotes are almost certainly required for anyone copy-pasting this code
into their shell.

- Updated the configuration in .../MavenExample/pom.xml to align with
what's in the manual. I confirmed that the configuration works with
OpenJDK 8 and 20.
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[com.google.errorprone:error_prone_annotations](https://errorprone.info)
([source](https://togithub.com/google/error-prone)) | `2.21.0` ->
`2.21.1` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.errorprone:error_prone_annotations/2.21.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.errorprone:error_prone_annotations/2.21.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.errorprone:error_prone_annotations/2.21.0/2.21.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.errorprone:error_prone_annotations/2.21.0/2.21.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [com.google.errorprone:error_prone_core](https://errorprone.info)
([source](https://togithub.com/google/error-prone)) | `2.21.0` ->
`2.21.1` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.errorprone:error_prone_core/2.21.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.errorprone:error_prone_core/2.21.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.errorprone:error_prone_core/2.21.0/2.21.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.errorprone:error_prone_core/2.21.0/2.21.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

<details>
<summary>google/error-prone
(com.google.errorprone:error_prone_annotations)</summary>

[`v2.21.1`](https://togithub.com/google/error-prone/releases/tag/v2.21.1):
Error Prone 2.21.1

[Compare
Source](https://togithub.com/google/error-prone/compare/v2.21.0...v2.21.1)

Changes:

- Handle overlapping ranges in suppressedRegions (fixes
[#&#8203;4040](https://togithub.com/google/error-prone/issues/4040))
- Add [` AddressSelection
`](https://errorprone.info/bugpattern/AddressSelection) to discourage
APIs that convert a hostname to a single address

Full Changelog:
google/error-prone@v2.21.0...v2.21.1

</details>

---

📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am
every weekday,every weekend" in timezone America/Los_Angeles, Automerge
- At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/typetools/checker-framework).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNy4xIiwidXBkYXRlZEluVmVyIjoiMzYuMjcuMSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
In typetools#5955, the `ExtendedNode` and `Label` classes from the dataflow
framework were changed from public to package-private. However, NullAway
relies on these classes being public (see
typetools#5156,
typetools#5152, and
uber/NullAway#608). This PR makes the classes
public again and adds an explanatory comment.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ixes typetools#6125 (typetools#6132)

The root directory for test fixtures is required in two places:

- in the test class so it can be configured with the correct source path by org.checkerframework.framework.test.TestConfigurationBuilder to compile the fixtures.
- in the test runner so it can find the test fixtures and inject them as the test's parameters.

Introduce a `@TestRootDirectory` annotation for tests to declare the location their test source fixtures. The absence of the annotation is the status-quo and the location will default to the current behaviour.

Refactoring of `CheckerFrameworkPerDirectoryTest` and `CheckerFrameworkPerFileTest` introduced a common superclass that may also be suitable for addressing the extant to do notes in these classes.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Chris Povirk <cpovirk@google.com>
Co-authored-by: Michael Ernst <mernst@cs.washington.edu>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@wmdietl wmdietl merged commit d4217a4 into typetools-3.38.0-fixes Oct 16, 2023
0 of 9 checks passed
@wmdietl wmdietl deleted the typetools-3.38.0-merge branch October 16, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants