Scan through members in InitializationFieldAccessVisitor
#619
Conversation
| @@ -24,6 +28,9 @@ public void processClassTree(ClassTree classTree) { | |||
| // and InitializationChecker, this checker performs the flow analysis | |||
| // (which is handled in the BaseTypeVisitor), but does not perform | |||
| // any type checking. | |||
| // Thus, this method does nothing. | |||
| // Thus, this method does nothing but scan through the members. | |||
| if (!assumeInitialized) { | |||
There was a problem hiding this comment.
@flo2702 This is the key change in this PR. Sorry for adding so many other changes while tracking this down.
I think I'll merge this PR now, to fix the exception. Can you open a new PR if you find a better fix?
There was a problem hiding this comment.
Agreed. I'll keep looking, but haven't found anything better.
| @@ -413,12 +413,12 @@ Before: InitializationStore#93( | |||
| ~~~~~~~~~ | |||
| o [ VariableDeclaration ] | |||
| (this) [ ImplicitThis ] | |||
| (this).f [ FieldAccess ] > CFAV{@Initialized, Object} | |||
| o = (this).f [ Assignment ] > CFAV{@Initialized, Object} | |||
| (this).f [ FieldAccess ] > CFAV{, T} | |||
There was a problem hiding this comment.
@flo2702 These changes come a bit as a surprise, but look good to me - field f has type T, so the new types look more precise than before, where it used the erasure.
There was a problem hiding this comment.
Seems like scanning through all members once in the visitor somehow allows more precise types to be used during the dataflow refinement. Probably something to consider while I look for a better fix, but I admit that I don't really understand how the visitor affects the refinement in this way.
The problem only occurs when the enclosing type is an annotation type, e.g. if
Issue612Minis changed from an@interfaceto aclass, the NPE doesn't happen.So maybe there is some more localized fix that undoes some special handling for annotation types.
@flo2702 can you have a look at this and see whether you find a better fix? The issue was introduced with #444 .
Fixes #612 .