Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't recursively call combine and substitute if the underlining type is raw #788

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Don't recursively call combine and substitute if the underlining type is raw #788

wants to merge 5 commits into from

Conversation

Ao-senXiong
Copy link
Member

Fixes #778

@Ao-senXiong Ao-senXiong changed the title Don't recursive when type parameter extends the class itself Don't recurse when type parameter extends the class itself Jul 4, 2024
@Ao-senXiong Ao-senXiong changed the title Don't recurse when type parameter extends the class itself Don't recursively call combine and subsitude if the underlining type is raw Aug 19, 2024
@Ao-senXiong Ao-senXiong changed the title Don't recursively call combine and subsitude if the underlining type is raw Don't recursively call combine and substitute if the underlining type is raw Aug 19, 2024
@Ao-senXiong
Copy link
Member Author

This PR fixes PICO's crash bug.

@Ao-senXiong Ao-senXiong removed their assignment Aug 19, 2024
@Ao-senXiong Ao-senXiong requested a review from wmdietl August 19, 2024 20:34
@Ao-senXiong
Copy link
Member Author

Ao-senXiong commented Aug 19, 2024 •
edited
Loading

This also fixes #443's comment entry 1

wmdietl
wmdietl requested changes Aug 23, 2024
View reviewed changes
Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, similar code that uses wildcards instead of raw types still crashes.

@wmdietl wmdietl assigned Ao-senXiong and unassigned wmdietl Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmdietl wmdietl wmdietl requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Ao-senXiong Ao-senXiong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stack overflow in combineAnnotationWithType when check generics extends itself to list
2 participants
@Ao-senXiong @wmdietl