Add lost qualifier to viewpointtest type checker #827
Conversation
TODO: lost is not reflexive |
framework/src/test/java/viewpointtest/ViewpointTestQualifierHierarchy.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Werner Dietl <wdietl@gmail.com>
| @@ -2,6 +2,7 @@ | |||
| receiver.invalid=incompatible types.%nfound : %s%nrequired: %s | |||
| type.anno.before.modifier=write type annotation %s immediately before type, after modifiers %s | |||
| type.anno.before.decl.anno=write type annotations %s immediately before type, after declaration annotation %s | |||
| new.class.type.invalid=the annotations %s do not need be applied in object creations | |||
There was a problem hiding this comment.
Can you move this further down to other type.invalid error messages.
While we're at it, can you improve the grammar?
framework/src/test/java/viewpointtest/ViewpointTestAnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
framework/src/test/java/viewpointtest/ViewpointTestViewpointAdapter.java
Outdated
Show resolved
Hide resolved
framework/src/test/java/viewpointtest/ViewpointTestVisitor.java
Outdated
Show resolved
Hide resolved
| @PolyVP MyClass(@PolyVP Object o) { | ||
| throw new RuntimeException(" * You are filled with DETERMINATION."); // stub | ||
| // :: warning: (cast.unsafe.constructor.invocation) | ||
| throw new @A RuntimeException(" * You are filled with DETERMINATION."); // stub |
There was a problem hiding this comment.
What's the point of this change? Should there be multiple versions?
There was a problem hiding this comment.
I expand the test suite in here.
| VarargsConstructor a = new VarargsConstructor("testStr", new Object()); | ||
| VarargsConstructor a = | ||
| // :: warning: (cast.unsafe.constructor.invocation) | ||
| new @A VarargsConstructor("testStr", new @A Object()); |
There was a problem hiding this comment.
Is this change illustrating something about Lost? Should there be versions of this test without an annotation? A comment would help understand this test.
There was a problem hiding this comment.
This change is not about lost, I update this test case because I want those invalid invocation because previous we allow @Top constructor invocation. More test cases for lost is in LostNonReflexive.java
framework/src/test/java/viewpointtest/ViewpointTestQualifierHierarchy.java
Outdated
Show resolved
Hide resolved
| @Override | ||
| public Void visitNewClass(NewClassTree tree, Void p) { | ||
| AnnotatedTypeMirror Type = atypeFactory.getAnnotatedType(tree); | ||
| if (Type.hasAnnotation(atypeFactory.TOP)) { |
There was a problem hiding this comment.
Shouldn't LOST also be forbidden?
There was a problem hiding this comment.
Yes, how about poly and RD qualifier? I left out those two as I feel like we need more discussion.
Co-authored-by: Werner Dietl <wdietl@gmail.com>
framework/src/test/java/viewpointtest/ViewpointTestViewpointAdapter.java
Outdated
Show resolved
Hide resolved
Fixes #576