Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daikon handling in CI, cleanups #830

Merged
merged 27 commits into from
Aug 9, 2024
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
b254ced
Don't block daikon on misc_jdk21
wmdietl Aug 7, 2024
cdb2d25
Attempt running daikon on GitHub Actions
wmdietl Aug 7, 2024
ffdccb6
Merge branch 'master' of github.com:eisop/checker-framework into azur…
wmdietl Aug 7, 2024
85bf2a2
Improve documentation
wmdietl Aug 7, 2024
6b4d10b
Only keep misc jobs in Azure Pipelines, run them in parallel
wmdietl Aug 7, 2024
706a2e1
Check daikon on all JDKs (is this worth it??), JDK 22 is not experime…
wmdietl Aug 7, 2024
0752928
Document absence of dependency
wmdietl Aug 7, 2024
d05394a
Add debugging output
wmdietl Aug 7, 2024
56c9d40
Revert "Add debugging output"
wmdietl Aug 8, 2024
c604a3f
Daikon fails with `this-escape` warnings in JDK 23+
wmdietl Aug 8, 2024
ba9dd31
Revert "Revert "Add debugging output""
wmdietl Aug 8, 2024
5c850b4
Document daikon exclusions.
wmdietl Aug 8, 2024
ad194d0
More debugging
wmdietl Aug 8, 2024
45063ed
Fix compilation error
wmdietl Aug 8, 2024
9e10cd8
Debugging
wmdietl Aug 8, 2024
b212704
Start undoing debugging output, see at what point it fails
wmdietl Aug 8, 2024
dc120e3
Undo
wmdietl Aug 8, 2024
e8ab042
Undo
wmdietl Aug 8, 2024
a16d78e
Comment out other tests for now
wmdietl Aug 8, 2024
3da3eef
Disable remainder
wmdietl Aug 8, 2024
55360db
Let's see whether `System.setErr` is the problem...
wmdietl Aug 8, 2024
7bfa32b
Things are still working...
wmdietl Aug 8, 2024
2a78128
Comment out output...
wmdietl Aug 8, 2024
a9792c7
Keep JDK 22 experimental until bug is fixed
wmdietl Aug 8, 2024
cff5a51
Only comment changes are left...
wmdietl Aug 8, 2024
9e1b684
Only remove comments...
wmdietl Aug 9, 2024
54c74df
Restore all jobs
wmdietl Aug 9, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,15 @@ jobs:
remainder:
name: ${{ matrix.script }} on JDK ${{ matrix.java_version }}
runs-on: ubuntu-latest
# Don't depend on sanity jobs, to have more parallelism.
# TODO: cancel these jobs if sanity fails.
# needs: sanity
permissions:
contents: read
strategy:
matrix:
# No need to run 'cftests-junit-jdk21' on JDK 21.
script: ['typecheck-part1', 'typecheck-part2', 'guava', 'plume-lib', 'jspecify-conformance']
script: ['typecheck-part1', 'typecheck-part2', 'guava', 'plume-lib', 'daikon-part1', 'daikon-part2', 'jspecify-conformance']
java_version: [21]
env:
JAVA_VERSION: ${{ matrix.java_version }}
Expand All @@ -67,19 +70,20 @@ jobs:
otherjdks:
name: ${{ matrix.script }} on JDK ${{ matrix.java.version }}
runs-on: ubuntu-latest
needs: remainder
needs: sanity
permissions:
contents: read
strategy:
fail-fast: false
matrix:
# jspecify-conformance only tested on JDK 21.
script: ['cftests-junit', 'cftests-nonjunit', 'cftests-junit-jdk21', 'typecheck-part1', 'typecheck-part2', 'guava', 'plume-lib']
script: ['cftests-junit', 'cftests-nonjunit', 'cftests-junit-jdk21',
'typecheck-part1', 'typecheck-part2', 'guava', 'plume-lib', 'daikon-part1', 'daikon-part2']
# JDK 21 used by sanity before
java: [{version: '8', experimental: false},
{version: '11', experimental: false},
{version: '17', experimental: false},
{version: '22', experimental: true},
{version: '22', experimental: false},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change means that the JDK 22 runtime is now also used to run the test cases - before, the JDK 21 runtime was used, as is the case for experimental platforms.
This reveals the failure with the non-junit tests, which is #826. So we either keep JDK 22 experimental or fix #826.

I can't reproduce the failures we get with :dataflow:busyExpressionTest and the last few runs don't produce them. Not sure what is causing this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:dataflow:busyExpressionTest fails again as soon as I remove the debugging for it in 56c9d40

{version: '23-ea', experimental: true},
{version: '24-ea', experimental: true}]
env:
Expand Down
Loading
Loading