forked from typetools/checker-framework
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daikon handling in CI, cleanups #830
Merged
Merged
Changes from 8 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
b254ced
Don't block daikon on misc_jdk21
wmdietl cdb2d25
Attempt running daikon on GitHub Actions
wmdietl ffdccb6
Merge branch 'master' of github.com:eisop/checker-framework into azur…
wmdietl 85bf2a2
Improve documentation
wmdietl 6b4d10b
Only keep misc jobs in Azure Pipelines, run them in parallel
wmdietl 706a2e1
Check daikon on all JDKs (is this worth it??), JDK 22 is not experime…
wmdietl 0752928
Document absence of dependency
wmdietl d05394a
Add debugging output
wmdietl 56c9d40
Revert "Add debugging output"
wmdietl c604a3f
Daikon fails with `this-escape` warnings in JDK 23+
wmdietl ba9dd31
Revert "Revert "Add debugging output""
wmdietl 5c850b4
Document daikon exclusions.
wmdietl ad194d0
More debugging
wmdietl 45063ed
Fix compilation error
wmdietl 9e10cd8
Debugging
wmdietl b212704
Start undoing debugging output, see at what point it fails
wmdietl dc120e3
Undo
wmdietl e8ab042
Undo
wmdietl a16d78e
Comment out other tests for now
wmdietl 3da3eef
Disable remainder
wmdietl 55360db
Let's see whether `System.setErr` is the problem...
wmdietl 7bfa32b
Things are still working...
wmdietl 2a78128
Comment out output...
wmdietl a9792c7
Keep JDK 22 experimental until bug is fixed
wmdietl cff5a51
Only comment changes are left...
wmdietl 9e1b684
Only remove comments...
wmdietl 54c74df
Restore all jobs
wmdietl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change means that the JDK 22 runtime is now also used to run the test cases - before, the JDK 21 runtime was used, as is the case for experimental platforms.
This reveals the failure with the non-junit tests, which is #826. So we either keep JDK 22 experimental or fix #826.
I can't reproduce the failures we get with
:dataflow:busyExpressionTest
and the last few runs don't produce them. Not sure what is causing this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:dataflow:busyExpressionTest
fails again as soon as I remove the debugging for it in 56c9d40