New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for HTTP to ping urls requiring a query parameter #25

Open

thothonegan wants to merge 1 commit into eitoball:master from thothonegan:fix-ping-http-with-query

thothonegan commented Mar 8, 2019

When pinging the google play store pages, it has the behavior that without a query parameter it fails ( https://play.google.com/store/apps/details vs https://play.google.com/store/apps/details?id=com.google.android.googlequicksearchbox ).

Ping::HTTP was only using the path instead of the full request part, so this switches to request_uri, which is what Net::HTTP uses.


          Add support for HTTP to ping urls requiring a query parameter

f10efdd

Collaborator

chernesk commented May 31, 2019

Sorry for the delay, I wasn't getting notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet