Make SAR build on the current Windows toolchain #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiz
force-pushed
the
mack/fix-compile-errors
branch
8 times, most recently
from
4cf1faa to
1790dbd
Compare
Bring the code up to bare minimum standard of buildability. Fix compile errors in topology pin code and remove win7 ifdefs to ensure the array length always matches. Remove calls to deprecated ExAllocatePoolWithTag function in favor of ExAllocatePool2. Retarget to current Windows SDK/WDK. Add required project settings. This is still relying on the WiX 3.x toolset. Build is now VS2022 community edition.
eiz
force-pushed
the
mack/fix-compile-errors
branch
from
678075e to
c442b36
Compare
TODO: github action for deploying artifacts.
eiz
force-pushed
the
mack/fix-compile-errors
branch
from
30087b5 to
9eb4ebf
Compare
eiz
changed the title
|
POG. Seriously though I'm curious if ExAllocatePool2 does anything differently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring the code up to bare minimum standard of buildability. Fix compile errors in topology pin code and remove win7 ifdefs to ensure the array length always matches. Remove calls to deprecated ExAllocatePoolWithTag function in favor of ExAllocatePool2. Retarget to current Windows SDK/WDK. Add required project settings. Remove SarNdis/etc from solution.
This is still relying on the WiX 3.x toolset. Build is now VS2022 community edition.
With these changes whatever vestige of win7 support still existed will go away due to WDK incompatibility.
AppVeyor's Visual Studio 2022 image did not have a version of the WDK installed which is actually compatible with Visual Studio 2022 (only the 2019 VSIX is present in that WDK version), so this PR also switches to GitHub Actions for CI.
Also due to WDK changes, the 32-bit kernel target of SAR no longer exists. There is only one .msi now and it is for 64-bit Windows 10 (version 2004) or later. The 32-bit SarAsio.dll is still built for compatibility with 32-bit apps.