Skip to content

Minor but critical tweaks to default options for DetailLine + Vendor objects #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 3, 2024
Merged

Minor but critical tweaks to default options for DetailLine + Vendor objects #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
10c47a9
Update detailline.py
jaredthecoder Jul 28, 2023
4335643
Update test_detailline.py
jaredthecoder Jul 28, 2023
c0e1dc2
Fix taxinclusiveamt and vendor setting 1099 creation
jaredthecoder Sep 15, 2023
363ac2f
Merge upstream ej2 version into Uncat version
jaredthecoder Dec 24, 2023
209ab02
Remove six imports added mistakenly
jaredthecoder Dec 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions quickbooks/objects/detailline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ class AccountBasedExpenseLineDetail(QuickbooksBaseObject):
def __init__(self):
super(AccountBasedExpenseLineDetail, self).__init__()
self.BillableStatus = None
self.TaxAmount = 0
self.TaxInclusiveAmt = 0

self.CustomerRef = None
Expand Down Expand Up @@ -234,8 +233,8 @@ def __init__(self):
super(ItemBasedExpenseLineDetail, self).__init__()
self.BillableStatus = None
self.UnitPrice = 0
self.TaxInclusiveAmt = 0
self.Qty = 0
self.TaxInclusiveAmt = 0
self.ItemRef = None
self.ClassRef = None
self.PriceLevelRef = None
Expand Down
2 changes: 1 addition & 1 deletion quickbooks/objects/vendor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def __init__(self):
self.Balance = 0
self.BillRate = 0
self.AcctNum = ""
self.Vendor1099 = True
self.Vendor1099 = False
self.TaxReportingBasis = ""

self.BillAddr = None
Expand Down
1 change: 0 additions & 1 deletion tests/unit/objects/test_detailline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ def test_init(self):

self.assertEqual(detail.BillableStatus, None)
self.assertEqual(detail.UnitPrice, 0)
self.assertEqual(detail.TaxInclusiveAmt, 0)
self.assertEqual(detail.Qty, 0)
self.assertEqual(detail.ItemRef, None)
self.assertEqual(detail.ClassRef, None)
Expand Down