Skip to content

Commit

Permalink
update gh login instructions after gh CLI storage update
Browse files Browse the repository at this point in the history
As shared [in this comment](#335 (comment)), gh cli has changed the default behavior of how github auth tokens are saved. This change makes spr no longer able to read github auth tokens and has caused myself and others confusion when instructions say to run `gh auth login` but still see spr not be able to find the token. 

This change updates the instructions to avoid this confusion. I do understand that suggesting to users to use insecure storage may not be ideal and a different solution may be preferred. Whatever solution it is, I believe it's better then today where users of spr receive these help docs, try them, and do not see success.
  • Loading branch information
levibostian authored Mar 7, 2024
1 parent 5ce5a01 commit 6fbc74b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion github/githubclient/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ No GitHub OAuth token found! You can either create one
at https://%s/settings/tokens and set the GITHUB_TOKEN environment variable,
or use the official "gh" CLI (https://cli.github.com) config to log in:
$ gh auth login
$ gh auth login --insecure-storage
Alternatively, configure a token manually in ~/.config/hub:
Expand Down

0 comments on commit 6fbc74b

Please sign in to comment.