Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to php 8 #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

update to php 8 #25

wants to merge 2 commits into from

Conversation

kirillkuralesin
Copy link

No description provided.

garex
garex requested changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@garex garex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Точно не так. Сделайте backward-compatible и обязательно добавить в .travis.yml версию для 8-ки.

^5.6 || ^7.0 || ^8.0

@kirillkuralesin
Copy link
Author

добавил

@garex
Copy link
Contributor

garex commented Jun 16, 2023

Huston, we have a problem. Трэвис то давно сдох для опенсорса. Надо как-то конвертнуть текущий CI на гитхаб-экшинс. А потом уже эту ветку поребейзить и проверить. Так что пока на паузе.

@garex garex added enhancement New feature or request improve ci blocked labels Jun 16, 2023
@gradientascent100
Copy link

Было бы круто, если еще появится поддержка psr/log v3 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garex garex garex requested changes

Assignees
No one assigned
Labels
blocked ci enhancement New feature or request improve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirillkuralesin @garex @gradientascent100