Skip to content

Commit

Permalink
Drop support for Symfony 5 due to incompatibility with monolog 3
Browse files Browse the repository at this point in the history
  • Loading branch information
lruozzi9 committed May 6, 2024
1 parent 035ab6c commit b096bd9
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 11 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ jobs:
deprecation: max[direct]=0

# symfony version
- php: 8.3
symfony: '^5.4'
- php: 8.3
symfony: '^6.4'
- php: 8.3
Expand Down
4 changes: 1 addition & 3 deletions Command/NotifyDeploymentCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,13 @@ class NotifyDeploymentCommand extends Command
public const EXIT_UNAUTHORIZED = 2;
public const EXIT_HTTP_ERROR = 3;

protected static $defaultName = 'newrelic:notify-deployment';

private $newrelic;

public function __construct(Config $newrelic)
{
$this->newrelic = $newrelic;

parent::__construct();
parent::__construct('newrelic:notify-deployment');
}

protected function configure(): void
Expand Down
12 changes: 6 additions & 6 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@
],
"require": {
"php": "^8.1",
"symfony/config": "^5.4|^6.4|^7.0",
"symfony/console": "^5.4|^6.4|^7.0",
"symfony/dependency-injection": "^5.4|^6.4|^7.0",
"symfony/event-dispatcher": "^5.4|^6.4|^7.0",
"symfony/http-kernel": "^5.4|^6.4|^7.0",
"symfony/config": "^6.4|^7.0",
"symfony/console": "^6.4|^7.0",
"symfony/dependency-injection": "^6.4|^7.0",
"symfony/event-dispatcher": "^6.4|^7.0",
"symfony/http-kernel": "^6.4|^7.0",
"monolog/monolog": "^3.0"
},
"require-dev": {
"matthiasnoback/symfony-dependency-injection-test": "^4.3|^5.1",
"symfony/framework-bundle": "^5.4|^6.4|^7.0",
"symfony/framework-bundle": "^6.4|^7.0",
"symfony/phpunit-bridge": "^5.3|^6.0|^7.0",
"twig/twig": "^1.32|^2.4|^3.0",
"symfony/monolog-bundle": "^3.10"
Expand Down

0 comments on commit b096bd9

Please sign in to comment.