feat(Setter): add: prepends setter #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a setter that prepends the element, like `cons`. For balance, we also add a setter that also appends the element to the tail, like `snoc`. We often use this when adding elements to list structures and other order-conscious things. When we are doing natural language processing, for example, and we are adding processed data, it is more natural to add the resulting processed data to the head side if the original input source is closer to the head. Naturally we can also construct the processing by adding the tail if we think hard enough, but we don't want to work hard at that since we only need to prepare a function. The naming of the `<>:~` function was lost with `~<>`, but considering that the `~` symbol in the lenses setter operator is basically on the right, I used the `:` operator to indicate that it is closer to the `cons` of the list, rather than focusing on the contrast.
|
Thanks, @ncaq! Looking at the |
Add "with result" variants. Code review reflected.
What === Move `(<|~)`, `(<|=)`, `(|>~)`, `(|>=)` from `Control.Lens.Setter` to `Control.Lens.Cons`. Why === I try impl with result variants to `Control.Lens.Lens` like other. This requires the import of `Control.Lens.Cons` in `Control.Lens.Lens`. But it cause cycle import. So I decided to implement Cons-related operators with `Control.Lens.Cons`.
|
@RyanGlScott |
Add Cons operators of "with result" variants.
|
I made a mistake in describing the test... |
RyanGlScott
added a commit
that referenced
this pull request
May 4, 2024
RyanGlScott
added a commit
that referenced
this pull request
May 11, 2024
RyanGlScott
added a commit
that referenced
this pull request
May 12, 2024
RyanGlScott
added a commit
that referenced
this pull request
May 12, 2024
As requested in #1068 (review).
RyanGlScott
added a commit
that referenced
this pull request
May 12, 2024
RyanGlScott
added a commit
that referenced
this pull request
May 12, 2024
As requested in #1068 (review).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a setter that prepends the element, like
cons. For balance, we also add a setter that also appends the element to the tail, likesnoc. We often use this when adding elements to list structures and other order-conscious things. When we are doing natural language processing, for example, and we are adding processed data, it is more natural to add the resulting processed data to the head side if the original input source is closer to the head. Naturally we can also construct the processing by adding the tail if we think hard enough, but we don't want to work hard at that since we only need to prepare a function. The naming of the<>:~function was lost with~<>, but considering that the~symbol in the lenses setter operator is basically on the right, I used the:operator to indicate that it is closer to theconsof the list, rather than focusing on the contrast.