Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade gatsby from 2.32.9 to 4.6.0 #100

Open
wants to merge 1 commit into
base: latest
Choose a base branch
from

Conversation

snyk-bot
Copy link

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

merge advice

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • grid-packages/ag-grid-docs/documentation/package.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
high severity 696/1000
Why? Proof of Concept exploit, Has a fix available, CVSS 7.5
Regular Expression Denial of Service (ReDoS)
SNYK-JS-ANSIREGEX-1583908
Yes Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: gatsby The new version differs by 250 commits.
  • 441e6da chore(release): Publish
  • ed1a9b5 fix(gatsby-cli): relax error location validation and ignore extra fields (#34559) (#34588)
  • e39f6cd fix(gatsby): don't remove onPluginInit in graphql-engine (#34558) (#34586)
  • 17e8698 feat(gatsby-plugin-gatsby-cloud): request customer feedback (#34471)
  • 94ffe33 chore(docs): Update client-only self-hosting instructions (#34537)
  • e1e55c9 chore(docs): Update FS route api client only splat description (#34546)
  • e9cd0ba chore(docs): Update links on gatsby-for-ecommerce (#34517)
  • 1f28c1c chore(changelogs): update changelogs (#34544)
  • d20c97b fix: add missing dependencies (#28759)
  • 42ed5ef fix(plugin-schema-snapshot): unlink file on init (#34527)
  • 195188c docs(migrating-from-v3-to-v4): correct getNode snippet (#34543)
  • d39265f docs(migrating-from-v2-to-v3): correct getNode snippet (#34542)
  • bb85cef chore(release): Publish next
  • 022ce14 fix(deps): update starters and examples gatsby packages to ^4.5.4 (#34541)
  • 3954944 fix(gatsby-remark-images): regenerate markdown when used image changes (#34433)
  • f5bb0b6 chore(circleci): pin renovate cli version (#34536)
  • 77e4bb0 fix(gatsby): handle session storage not being available (#34525)
  • d2ba1f9 perf: move id: eq fast path handling to node-model so it's shared between query running strategies (#34520)
  • a3fa646 feat(gatsby-sharp): create more resilient wrapper around sharp (#34339)
  • d319983 chore(changelogs): update changelogs (#34521)
  • f10d0e5 feat(gatsby): content sync debugging tweaks (#34487)
  • 15e549c fix(deps): update starters and examples - gatsby (#34515)
  • 7387918 chore(docs): Update links on plugins overview doc (#34479)
  • 44b2ef5 fix(create-gatsby): Respect telemetry disable (#34495)

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic

…vulnerabilities

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-ANSIREGEX-1583908
@pull-request-quantifier-deprecated

This PR has 2 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +1 -1
Percentile : 0.8%

Total files changed: 1

Change summary by file extension:
.json : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant