Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade nginx from 1.19.3-alpine to 1.25.1-alpine #546

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ekmixon
Copy link
Owner

@ekmixon ekmixon commented Feb 20, 2024

This PR was automatically created by Snyk using the credentials of a real user.


Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.

Changes included in this PR

  • devenv/docker/blocks/prometheus_basic_auth_proxy/Dockerfile

We recommend upgrading to nginx:1.25.1-alpine, as this image has only 17 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.

Some of the most important vulnerabilities in your base image include:

Severity Priority Score / 1000 Issue Exploit Maturity
critical severity 714 Out-of-bounds Read
SNYK-ALPINE312-APKTOOLS-1533753
No Known Exploit
critical severity 714 Double Free
SNYK-ALPINE312-CURL-1585256
No Known Exploit
critical severity 714 Double Free
SNYK-ALPINE312-CURL-1585256
No Known Exploit
critical severity 714 Out-of-bounds Write
SNYK-ALPINE312-FREETYPE-2809179
No Known Exploit
critical severity 714 Out-of-bounds Write
SNYK-ALPINE312-ZLIB-2977082
No Known Exploit

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Micro-Learning Topic: Double free (Detected by phrase)

Matched on "Double Free"

What is this? (2min video)

Double free errors occur when free() is called more than once with the same memory address as an argument.

Try a challenge in Secure Code Warrior

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: This pull request addresses the need to update the Docker base image for the Prometheus basic auth proxy from nginx version 1.19.3-alpine to 1.25.1-alpine. The update is motivated by the desire to leverage security fixes available in the newer version of the nginx image, which has significantly fewer known vulnerabilities. The changes are confined to the Dockerfile of the prometheus_basic_auth_proxy block, ensuring that the nginx base image is updated accordingly.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.

General suggestions:

  • After merging this PR, it's crucial to conduct thorough testing to ensure that the application continues to function as expected with the new nginx base image. This includes verifying that all configurations and dependencies are compatible with nginx version 1.25.1-alpine.
  • Consider reviewing the changelog for nginx version 1.25.1-alpine to identify any deprecated features or significant changes that could impact the application. This will help in proactively addressing potential issues.
  • Given the security context of this update, it might be beneficial to document the specific vulnerabilities addressed by moving to nginx version 1.25.1-alpine. This documentation can be useful for future reference and for stakeholders interested in the security posture of the application.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@@ -1,4 +1,4 @@
FROM nginx:1.19.3-alpine
FROM nginx:1.25.1-alpine
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 security (llm): This change updates the nginx base image to version 1.25.1-alpine. Ensure that this version is compatible with all dependencies and does not introduce any security vulnerabilities.

Copy link

guardrails bot commented Feb 20, 2024

⚠️ We detected 1 security issue in this pull request:

Insecure Access Control (1)
Severity Details Docs
High Title: Missing User Instruction
📚

More info on how to fix Insecure Access Control in Dockerfile.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

Micro-Learning Topic: Insufficient access control (Detected by phrase)

Matched on "Insecure Access Control"

Restrictions on what authenticated users are allowed to do are often not properly enforced. Attackers can exploit these flaws to access unauthorized functionality and/or data, such as access other users' accounts, view sensitive files, modify other users’ data, change access rights, etc. Source: https://www.owasp.org/index.php/Category:OWASP_Top_Ten_Project

Try a challenge in Secure Code Warrior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants