Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade nginx from 1.19.3-alpine to 1.27.3-alpine #669

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ekmixon
Copy link
Owner

@ekmixon ekmixon commented Dec 2, 2024

snyk-top-banner

Snyk has created this PR to fix 4 vulnerabilities in the dockerfile dependencies of this project.

Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.

Snyk changed the following file(s):

  • devenv/docker/blocks/nginx_proxy_mac/Dockerfile

We recommend upgrading to nginx:1.27.3-alpine, as this image has only 0 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
critical severity Out-of-bounds Read
SNYK-ALPINE312-APKTOOLS-1533753
  714  
critical severity Double Free
SNYK-ALPINE312-CURL-1585256
  714  
critical severity Double Free
SNYK-ALPINE312-CURL-1585256
  714  
critical severity Out-of-bounds Write
SNYK-ALPINE312-FREETYPE-2809179
  714  
critical severity Out-of-bounds Write
SNYK-ALPINE312-ZLIB-2977082
  714  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Double Free

Summary by Sourcery

Bug Fixes:

  • Upgrade nginx base image in Dockerfile to address multiple critical vulnerabilities including out-of-bounds read, double free, and out-of-bounds write issues.

Micro-Learning Topic: Double free (Detected by phrase)

Matched on "Double Free"

What is this? (2min video)

Double free errors occur when free() is called more than once with the same memory address as an argument.

Try a challenge in Secure Code Warrior

Copy link

sourcery-ai bot commented Dec 2, 2024

Reviewer's Guide by Sourcery

This PR updates the NGINX base image from version 1.19.3-alpine to 1.27.3-alpine to address multiple critical security vulnerabilities. The change is implemented through a simple version bump in the Dockerfile, which will pull the newer, more secure NGINX image during container builds.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update NGINX base image to patch security vulnerabilities
  • Upgrade NGINX version from 1.19.3-alpine to 1.27.3-alpine
  • Fix critical Out-of-bounds Read vulnerability in apk-tools
  • Fix critical Double Free vulnerability in curl
  • Fix critical Out-of-bounds Write vulnerability in freetype
  • Fix critical Out-of-bounds Write vulnerability in zlib
devenv/docker/blocks/nginx_proxy_mac/Dockerfile

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. Here's why:

  • It seems to have been created by a bot ('[Snyk]' found in title). We assume it knows what it's doing!
  • We don't review packaging changes - Let us know if you'd like us to change this.

Copy link

guardrails bot commented Dec 2, 2024

⚠️ We detected 1 security issue in this pull request:

Insecure Access Control (1)
Severity Details Docs
High Title: Missing User Instruction
📚

More info on how to fix Insecure Access Control in Dockerfile.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

Micro-Learning Topic: Insufficient access control (Detected by phrase)

Matched on "Insecure Access Control"

Restrictions on what authenticated users are allowed to do are often not properly enforced. Attackers can exploit these flaws to access unauthorized functionality and/or data, such as access other users' accounts, view sensitive files, modify other users’ data, change access rights, etc. Source: https://www.owasp.org/index.php/Category:OWASP_Top_Ten_Project

Try a challenge in Secure Code Warrior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants