Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): replace golang mock by uber-go mock #249

Merged
merged 1 commit into from
May 28, 2024

Conversation

katsuharu
Copy link
Contributor

Hi there! 👋

I've created a pull request to address the issue #248. In this PR, I've implemented the following changes:

Please review the changes and let me know if there's anything else needed or if further adjustments are required. Looking forward to your feedback!

Thank you!

@katsuharu katsuharu force-pushed the replace-gomock-uber branch from b4ec7be to 7e54640 Compare May 24, 2024 16:16
Copy link
Owner

@eko eko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update @katsuharu

@eko
Copy link
Owner

eko commented May 28, 2024

Could you please just rebase with the master branch? I've updated library to v4.1.6 on all stores so there is a conflict on go.mod now.

Thank you!

@katsuharu
Copy link
Contributor Author

@eko
Thank you for your review!

Sure, I’ll rebase with the master branch and resolve the conflict.

@katsuharu katsuharu force-pushed the replace-gomock-uber branch from 7e54640 to 1d50ba7 Compare May 28, 2024 10:28
@katsuharu
Copy link
Contributor Author

@eko
Thank you for your feedback! I've rebased the changes as requested and pushed the updates to the PR. Please take another look at your earliest convenience.

@katsuharu katsuharu force-pushed the replace-gomock-uber branch from 1d50ba7 to 485d5a3 Compare May 28, 2024 10:41
@eko eko merged commit 6d59150 into eko:master May 28, 2024
10 checks passed
@eko
Copy link
Owner

eko commented May 28, 2024

Thank you @katsuharu!

@katsuharu katsuharu deleted the replace-gomock-uber branch May 28, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants