Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --config-file to all commands #1126

Closed
errordeveloper opened this issue Aug 9, 2019 · 6 comments
Closed

add --config-file to all commands #1126

errordeveloper opened this issue Aug 9, 2019 · 6 comments
Assignees
Labels

Comments

@errordeveloper
Copy link
Contributor

errordeveloper commented Aug 9, 2019

Currently some commands still don't support --config-file, we should add it to all commands, and add --validate as well to allow users to control validation (#1124 already adds a field for it).
Verify that all commands support these flags

@Callisto13
Copy link
Contributor

Callisto13 commented Nov 30, 2020

For anyone coming by to pick part of this up, these are the commands which as yet do not support the --config-file flag:

  • get cluster
  • get labels
  • set labels
    - [ ] unset labels see comment at bottom of thread
  • utils describe-stacks
    - [ ] utils schema doesn't require cfg file
    - [ ] utils update-cluster-stack command removed
  • utils update-legacy-subnet-settings
  • utils write-kubeconfig

@neha-viswanathan
Copy link
Contributor

Hello I can pick this up

@Callisto13
Copy link
Contributor

Hey @neha-viswanathan sure, go for it!

I think let's have a PR for each action, to make reviewing etc easier 👍

@Skarlso
Copy link
Contributor

Skarlso commented Nov 16, 2021

  • get nodegroup

@aclevername
Copy link
Contributor

Not sure if its worth adding support for eksctl unset labels. The current suggested flow:

eksctl unset labels --cluster managed-cluster --nodegroup managed-ng-1 --labels kubernetes.io/managed-by,kubernetes.io/role

Having a cfg file option would only be useful for removing ALL labels. I don't know if thats really useful, it might just add more confusion.

@aclevername aclevername changed the title add --config-file add --config-file to all commands Jan 10, 2022
@aclevername
Copy link
Contributor

--validate flag no longer appears to be a thing:

cd pkg/ctl/

rg "\"validate\""

torredil pushed a commit to torredil/eksctl that referenced this issue May 20, 2022
images: fix invalid k8s-staging-test-infra/gcb-docker-gcloud tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants