Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validation of mixed instances with cpuCredits option #2454

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Fix validation of mixed instances with cpuCredits option #2454

merged 1 commit into from
Jul 20, 2020

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Jul 17, 2020 •
edited
Loading

Description

These merges are problematic, they make nasty PR commit lists. But the changeset is correct. #2453 fixing #2452 on master

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@michaelbeaumont michaelbeaumont added kind/bug skip-release-notes Causes PR not to show in release notes labels Jul 17, 2020
@michaelbeaumont michaelbeaumont requested a review from cPu1 July 17, 2020 15:15
cPu1
cPu1 reviewed Jul 20, 2020
View reviewed changes
Copy link
Contributor

@cPu1 cPu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just apply this changelist on top on master to avoid polluting the commit history?

@michaelbeaumont
Copy link
Contributor Author

I'll just squash it 👍

@michaelbeaumont michaelbeaumont merged commit 47f8fd4 into eksctl-io:master Jul 20, 2020
@michaelbeaumont michaelbeaumont deleted the fix_credits branch July 20, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 cPu1 approved these changes

Assignees
No one assigned
Labels
kind/bug skip-release-notes Causes PR not to show in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelbeaumont @cPu1