Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpend and fix Windows integration tests #4442

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Conversation

cPu1
Copy link
Contributor

@cPu1 cPu1 commented Nov 10, 2021

Description

The workload being deployed is not compatible with WindowsServer20H2CoreContainer and that was preventing the pod from starting. I have opened a separate issue to test workloads on WindowsServer20H2CoreContainer.

Closes #4414

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

The workload being deployed is not compatible with WindowsServer20H2CoreContainer and that was preventing the pod from starting.
@cPu1 cPu1 added the kind/bug label Nov 10, 2021
@cPu1 cPu1 enabled auto-merge November 10, 2021 12:07
@cPu1 cPu1 merged commit 165e391 into eksctl-io:main Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing windows test
2 participants