Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow additional volume mappings #4725

Merged
merged 17 commits into from
Feb 3, 2022
Merged

Allow additional volume mappings #4725

merged 17 commits into from
Feb 3, 2022

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Jan 31, 2022 •
edited
Loading

Closes #2115

Todo:

Probably some better docs.

Manual Test

apiVersion: eksctl.io/v1alpha5
kind: ClusterConfig

metadata:
  name: test-additional-volumes-2
  region: us-west-2
  version: '1.20'

managedNodeGroups:
  - name: managed-ng-1
    minSize: 1
    maxSize: 4
    desiredCapacity: 1
    additionalVolumes:
      - volumeName: '/dev/sdb'
➜  additional-volumes eksctl create cluster -f cluster-managed.yaml
...
2022-02-01 14:39:50 [ℹ]  nodegroup "managed-ng-1" has 1 node(s)
2022-02-01 14:39:50 [ℹ]  node "ip-192-168-76-90.us-west-2.compute.internal" is ready
2022-02-01 14:39:52 [ℹ]  kubectl command should work with "/Users/skarlso/.kube/config", try 'kubectl get nodes'
2022-02-01 14:39:52 [✔]  EKS cluster "test-additional-volumes-2" in "us-west-2" region is ready

Screenshot 2022-02-01 at 14 43 09

TODO:

Update the acceptance test

Currently running acceptance test....

using API server https://7D1D98844D284ED6A487D4A8270C7A95.gr7.us-west-2.eks.amazonaws.com

• [SLOW TEST:350.853 seconds]
(Integration) Create Managed Nodegroups
/Users/skarlso/goprojects/weaveworks/eksctl/integration/tests/managed/managed_nodegroup_test.go:57
  cluster with 1 al2 managed nodegroup
  /Users/skarlso/goprojects/weaveworks/eksctl/integration/tests/managed/managed_nodegroup_test.go:159
    supports adding bottlerocket and ubuntu nodegroups with additional volumes
    /Users/skarlso/goprojects/weaveworks/eksctl/integration/tests/managed/managed_nodegroup_test.go:160
....
Ran 1 of 21 Specs in 1665.693 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 20 Skipped
PASS | FOCUSED

Same for running unmanaged nodegroups.

Ran 1 of 43 Specs in 2362.203 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 42 Skipped
PASS | FOCUSED

@Skarlso Skarlso added the kind/feature New feature or request label Jan 31, 2022
aclevername
aclevername previously approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@aclevername aclevername left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth updating an existing integration test? lgtm

@Skarlso Skarlso dismissed aclevername’s stale review February 2, 2022 09:24

Lots of changes since, please re-review. thanks!: )

@Skarlso
Copy link
Contributor Author

Skarlso commented Feb 2, 2022

does this work for unmanaged?

The change set includes changes in both of the unit tests and acceptance tests.

Also, see my comment here:

Same for running unmanaged nodegroups.

Ran 1 of 43 Specs in 2362.203 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 42 Skipped
PASS | FOCUSED

@aclevername
Copy link
Contributor

does this work for unmanaged?

The change set includes changes in both of the unit tests and acceptance tests.

Also, see my comment here:

Same for running unmanaged nodegroups.

Ran 1 of 43 Specs in 2362.203 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 42 Skipped
PASS | FOCUSED

yeah I deleted my comment after I realised haha

aclevername
aclevername approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@aclevername aclevername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

cPu1
cPu1 approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@cPu1 cPu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have suggested some minor improvements in the integration tests but otherwise LGTM! 🎉

@Skarlso @cPu1
Apply suggestions from code review
6464e5e 
Co-authored-by: Chetan Patwal <cPu1@users.noreply.github.com>
@Skarlso Skarlso merged commit 8cc6c7c into eksctl-io:main Feb 3, 2022
@Skarlso Skarlso deleted the configure-additional-volumes branch February 3, 2022 12:32
@cvlc cvlc mentioned this pull request Feb 21, 2022
Merged
@Skarlso Skarlso mentioned this pull request Mar 29, 2022
Closed
@hspencer77 hspencer77 mentioned this pull request Jul 8, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 cPu1 approved these changes

@aclevername aclevername aclevername approved these changes

@nikimanoledaki nikimanoledaki Awaiting requested review from nikimanoledaki

@Himangini Himangini Awaiting requested review from Himangini

Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow more granular control over volume configuration on NodeGroup
3 participants
@Skarlso @aclevername @cPu1