Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated field that breaks upgrade nodegroup timeout value #4825

Merged
merged 3 commits into from
Feb 22, 2022

Conversation

aclevername
Copy link
Contributor

@aclevername aclevername commented Feb 22, 2022

Description

Closes #4787

before (print added for debugging):

2022-02-22 11:22:40 [ℹ]  eksctl version 0.86.0-dev+551fd9a4.2022-02-22T11:21:57Z
2022-02-22 11:22:40 [ℹ]  using region us-west-2
2022-02-22 11:22:41 [ℹ]  25m0s

after

2022-02-22 11:25:48 [ℹ]  eksctl version 0.86.0-dev+b7418e27.2022-02-22T11:25:02Z
2022-02-22 11:25:48 [ℹ]  using region us-west-2
2022-02-22 11:25:49 [ℹ]  45m0s

Copy link
Contributor

@cPu1 cPu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted! We should also check if there are any commands relying on this behaviour.

@aclevername
Copy link
Contributor Author

Well spotted! We should also check if there are any commands relying on this behaviour.

good point. I think this flag was causing ALL of the commands to have this default timeout value, but only some commands had the AddTimeoutFlag call done after the AddCommonAWS which is what made it work. I've changed it so that a new Cmd has this set by default, so those who configure the timeout flag will still override it, but it should preserve the previous behaviour of 25m being default

@aclevername aclevername enabled auto-merge (squash) February 22, 2022 14:17
@aclevername aclevername merged commit ab6eec2 into eksctl-io:main Feb 22, 2022
@hspencer77 hspencer77 mentioned this pull request Jul 8, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default timeout isn't respected in upgrade nodegroup
3 participants