Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove circleci #4844

Merged
merged 1 commit into from
Feb 25, 2022
Merged

remove circleci #4844

merged 1 commit into from
Feb 25, 2022

Conversation

aclevername
Copy link
Contributor

@aclevername aclevername commented Feb 25, 2022 •
edited
Loading

Description

Also removed the deploy key and webhook manually

last part of #4769

rg --hidden circleci
.git/
....

docs/proposal-006-build-improvements.md
109:We currently have rather complicated [CircleCI config](https://github.com/weaveworks/eksctl/blob/950f9bc695234107725234b9e1a9c9d2ee54e51f/.circleci/config.yml#L3-L38),
113:New configuration is much simpler, in [CircleCI config](https://github.com/weaveworks/eksctl/blob/d3b6988562b14c9d91f4e1bf7dd2c086e06c2383/.circleci/config.yml#L3-L24)

docs/release_notes/0.15.0.md
18:- Store artifacts created during release and rc jobs in circleci (#1864)

@aclevername aclevername added the skip-release-notes Causes PR not to show in release notes label Feb 25, 2022
@aclevername aclevername enabled auto-merge (squash) February 25, 2022 13:47
@aclevername aclevername merged commit b75fb4f into main Feb 25, 2022
@aclevername aclevername deleted the remove-circleci branch February 25, 2022 14:06
@Skarlso
Copy link
Contributor

Skarlso commented Feb 25, 2022

@aclevername Frek. I just noticed the CONTRIBUTION.md

Our CircleCI integration will run the automated tests and give you feedback in the review section. We will review your
changes and give you feedback as soon as possible. We also encourage people to post
links to their PRs in slack to get more eyes on the work.

@hspencer77 hspencer77 mentioned this pull request Jul 8, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skarlso Skarlso Skarlso approved these changes

@Himangini Himangini Awaiting requested review from Himangini

@nikimanoledaki nikimanoledaki Awaiting requested review from nikimanoledaki

Assignees
No one assigned
Labels
skip-release-notes Causes PR not to show in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aclevername @Skarlso