Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing stack name in case only the stack is provided. #4894

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Fix missing stack name in case only the stack is provided. #4894

merged 1 commit into from
Mar 4, 2022

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Mar 4, 2022

Description

Closes #4821

Fixed missing stack name from options.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

cPu1
cPu1 reviewed Mar 4, 2022
View reviewed changes
pkg/cfn/manager/api_test.go
Comment on lines +60 to +63
// 1) DescribeStacks
// 2) CreateChangeSet
// 3) DescribeChangeSetRequest (FAILED to abort early)
// 4) DescribeChangeSet (StatusReason contains "The submitted information didn't contain changes" to exit with noChangeError)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is helpful.

cPu1
cPu1 approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@cPu1 cPu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Skarlso Skarlso merged commit 0e53fd1 into eksctl-io:main Mar 4, 2022
@Skarlso Skarlso deleted the fix_addon_stack_name branch March 4, 2022 09:03
@hspencer77 hspencer77 mentioned this pull request Jul 8, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 cPu1 approved these changes

@aclevername aclevername Awaiting requested review from aclevername

@Himangini Himangini Awaiting requested review from Himangini

@nikimanoledaki nikimanoledaki Awaiting requested review from nikimanoledaki

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"eksctl update addon -f config.yaml" throws InvalidParameter (empty stack name)
2 participants
@Skarlso @cPu1