separate KMS into its own suite and reduce nodegroup creation time #4900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aclevername
commented
Mar 4, 2022
Comment on lines
-169
to
-181
| Context("Creating a cluster without --fargate", func() { | ||
| ft := &fargateTest{} | ||
|
|
||
| BeforeEach(func() { | ||
| setup(ft) | ||
| }) | ||
|
|
||
| It("should allow creation of new Fargate profiles", func() { | ||
| testCreateFargateProfile(ft.clusterName, ft.kubeTest) | ||
| }) | ||
|
|
||
| AfterEach(func() { | ||
| deleteCluster(ft.clusterName) |
There was a problem hiding this comment.
tested already in unowned suite
aclevername
commented
Mar 4, 2022
Comment on lines
-152
to
-167
| Context("Creating a cluster with --fargate and --managed", func() { | ||
| ft := &fargateTest{} | ||
|
|
||
| BeforeEach(func() { | ||
| setup(ft, "--fargate", "--managed") | ||
| }) | ||
|
|
||
| It("should support Fargate", func() { | ||
| testDefaultFargateProfile(ft.clusterName, ft.kubeTest) | ||
| testCreateFargateProfile(ft.clusterName, ft.kubeTest) | ||
| }) | ||
|
|
||
| AfterEach(func() { | ||
| deleteCluster(ft.clusterName) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
I didn't really get the point of this tbh why does testing fargate when a managed nodegroup exists need its own test? Its also tested in unowned suite
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4847
Passed locally, got a full run queue'd https://github.com/weaveworks/eksctl-ci/actions/runs/1934052828