Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix schema.json #4921

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Fix schema.json #4921

merged 2 commits into from
Mar 9, 2022

Conversation

cPu1
Copy link
Contributor

@cPu1 cPu1 commented Mar 9, 2022 •
edited
Loading

Description

#4912 fixed the doc link in godoc comments, but the schema wasn't generated from it. This changelist regenerates the schema.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@cPu1 cPu1 added area/tech-debt Leftover improvements in code, testing and building skip-release-notes Causes PR not to show in release notes labels Mar 9, 2022
@Himangini Himangini requested a review from a team March 9, 2022 13:49
Himangini
Himangini approved these changes Mar 9, 2022
View reviewed changes
Copy link
Collaborator

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@cPu1 cPu1 enabled auto-merge March 9, 2022 13:50
@Himangini Himangini requested a review from a team March 9, 2022 13:50
@cPu1 cPu1 merged commit 39b891d into eksctl-io:main Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclevername aclevername aclevername approved these changes

@Himangini Himangini Himangini approved these changes

Assignees
No one assigned
Labels
area/tech-debt Leftover improvements in code, testing and building skip-release-notes Causes PR not to show in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cPu1 @Himangini @aclevername