Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notes for 0.88 #4943

Merged
merged 2 commits into from
Mar 14, 2022
Merged

Add notes for 0.88 #4943

merged 2 commits into from
Mar 14, 2022

Conversation

nikimanoledaki
Copy link
Contributor

@nikimanoledaki nikimanoledaki commented Mar 14, 2022 •
edited
Loading

Description

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@nikimanoledaki nikimanoledaki added the skip-release-notes Causes PR not to show in release notes label Mar 14, 2022
@nikimanoledaki nikimanoledaki requested a review from a team March 14, 2022 08:59
@nikimanoledaki nikimanoledaki enabled auto-merge (squash) March 14, 2022 09:04
@nikimanoledaki nikimanoledaki requested a review from a team March 14, 2022 09:09
@nikimanoledaki nikimanoledaki merged commit 9b0e52f into eksctl-io:main Mar 14, 2022
@nikimanoledaki
Copy link
Contributor Author

@Skarlso @Himangini @cPu1 @aclevername wow everybody showed up 😂 thanks everybody hahahaha

@hspencer77 hspencer77 mentioned this pull request Jul 8, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skarlso Skarlso Skarlso approved these changes

@cPu1 cPu1 cPu1 approved these changes

@Himangini Himangini Himangini approved these changes

@aclevername aclevername aclevername approved these changes

Assignees
No one assigned
Labels
skip-release-notes Causes PR not to show in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nikimanoledaki @Skarlso @cPu1 @Himangini @aclevername