Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use go 1.18 for build all distros #4992

Merged
merged 4 commits into from
Mar 23, 2022
Merged

use go 1.18 for build all distros #4992

merged 4 commits into from
Mar 23, 2022

Conversation

aclevername
Copy link
Contributor

@aclevername aclevername commented Mar 23, 2022 •
edited
Loading

Description

it was causing build all distros to fail https://github.com/weaveworks/eksctl/runs/5657860907?check_suite_focus=true

go: downloading github.com/Azure/go-autorest/autorest/to v0.4.0
go: downloading github.com/Azure/go-autorest/autorest/validation v0.3.1
# github.com/goreleaser/goreleaser/pkg/context
Error: ../../../go/pkg/mod/github.com/goreleaser/goreleaser@v1.7.0/pkg/context/context.go:151:15: undefined: strings.Cut
note: module requires Go 1.18
make: *** [Makefile:39: install-build-deps] Error 2
Error: Process completed with exit code 2.

green run: https://github.com/weaveworks/eksctl/actions/runs/2027554554

@aclevername aclevername added the skip-release-notes Causes PR not to show in release notes label Mar 23, 2022
@aclevername aclevername requested a review from a team March 23, 2022 09:39
nikimanoledaki
nikimanoledaki approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@nikimanoledaki nikimanoledaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@aclevername aclevername enabled auto-merge (squash) March 23, 2022 11:15
@aclevername aclevername disabled auto-merge March 23, 2022 11:15
@aclevername aclevername enabled auto-merge (squash) March 23, 2022 11:15
@aclevername aclevername requested a review from a team March 23, 2022 11:21
@aclevername aclevername merged commit 82a94f8 into main Mar 23, 2022
@aclevername aclevername deleted the revert-goreleaser branch March 23, 2022 15:02
@hspencer77 hspencer77 mentioned this pull request Jul 8, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 cPu1 approved these changes

@nikimanoledaki nikimanoledaki nikimanoledaki approved these changes

Assignees
No one assigned
Labels
skip-release-notes Causes PR not to show in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aclevername @cPu1 @nikimanoledaki