Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add windows 20H20 integration test #5000

Merged
merged 4 commits into from
Apr 4, 2022
Merged

add windows 20H20 integration test #5000

merged 4 commits into from
Apr 4, 2022

Conversation

aclevername
Copy link
Contributor

@aclevername aclevername commented Mar 24, 2022 •
edited
Loading

Description

closes #4441

passes locally:

[0] JUnit report was created: /home/jake/weave/eksctl/test-results/__home__jake__weave__eksctl__integration__tests__windows__windows__test__go_1.xml
[0]
[0] Ran 3 of 3 Specs in 5026.405 seconds
[0] SUCCESS! -- 3 Passed | 0 Failed | 0 Pending | 0 Skipped
[0] PASS
[0]

@aclevername aclevername added the skip-release-notes Causes PR not to show in release notes label Mar 24, 2022
@aclevername aclevername requested a review from a team March 24, 2022 16:39
@aclevername aclevername marked this pull request as draft March 25, 2022 09:45
@Skarlso
Copy link
Contributor

Skarlso commented Mar 28, 2022

@aclevername Is this ready to review? It's in draft.

@aclevername
Copy link
Contributor Author

@aclevername Is this ready to review? It's in draft.

it was, but then its causing another test to fail some I'm investigating. so no not for the moment

@aclevername aclevername marked this pull request as ready for review April 1, 2022 10:33
@aclevername aclevername enabled auto-merge (squash) April 4, 2022 08:39
@aclevername aclevername requested a review from a team April 4, 2022 08:40
@aclevername
Copy link
Contributor Author

green run https://github.com/weaveworks/eksctl-ci/actions/runs/2078070999

@aclevername aclevername merged commit 9d9fc77 into main Apr 4, 2022
@aclevername aclevername deleted the 20h2 branch April 4, 2022 08:54
SlevinWasAlreadyTaken pushed a commit to SlevinWasAlreadyTaken/eksctl that referenced this pull request Apr 11, 2022
@aclevername @SlevinWasAlreadyTaken
add windows 20H20 integration test (eksctl-io#5000)
e926d70
@hspencer77 hspencer77 mentioned this pull request Jul 8, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skarlso Skarlso Skarlso approved these changes

@cPu1 cPu1 cPu1 approved these changes

Assignees
No one assigned
Labels
skip-release-notes Causes PR not to show in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add integration tests for running workloads on WindowsServer20H2CoreContainer
3 participants
@aclevername @Skarlso @cPu1