Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mkdocs #5008

Merged
merged 2 commits into from
Mar 28, 2022
Merged

Update mkdocs #5008

merged 2 commits into from
Mar 28, 2022

Conversation

nikimanoledaki
Copy link
Contributor

@nikimanoledaki nikimanoledaki commented Mar 28, 2022 •
edited
Loading

Description

The link checker step broke because of mkdocs breaking due to one of its dependencies. For more info: mkdocs/mkdocs#2799 - thanks @Skarlso for finding this!

Updating mkdocs to fix this.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@nikimanoledaki nikimanoledaki added the skip-release-notes Causes PR not to show in release notes label Mar 28, 2022
@nikimanoledaki nikimanoledaki requested a review from a team March 28, 2022 08:45
@nikimanoledaki nikimanoledaki enabled auto-merge (squash) March 28, 2022 08:45
@nikimanoledaki nikimanoledaki requested a review from a team March 28, 2022 08:46
@nikimanoledaki nikimanoledaki merged commit 97c24d5 into eksctl-io:main Mar 28, 2022
@hspencer77 hspencer77 mentioned this pull request Jul 8, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclevername aclevername aclevername approved these changes

@Skarlso Skarlso Skarlso approved these changes

Assignees
No one assigned
Labels
skip-release-notes Causes PR not to show in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikimanoledaki @Skarlso @aclevername