Remove dependency on STS v1 by removing the need to use aws-iam-authenticator for token generation #5016

Skarlso · 2022-03-29T14:08:23Z

Description

Closes #4993 by removing the aws-iam-authenticator dependency completely.

Added some removal of STSv1 as well, but did not yet rename STSV2. That will be in the next PR.

Checklist

Added tests that cover your change (if possible)
Added/modified documentation as required (such as the README.md, or the userdocs directory)
Manually tested
Made sure the title of the PR is a good description that can go into the release notes
(Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

Backfilled missing tests for code in same general area 🎉
Refactored something and made the world a better place 🌟

Skarlso · 2022-03-29T14:55:43Z

pkg/eks/api.go

@@ -213,15 +207,6 @@ func New(spec *api.ProviderConfig, clusterSpec *api.ClusterConfig) (*ClusterProv
 	provider.ec2 = ec2.New(s)
 	provider.elb = elb.New(s)
 	provider.elbv2 = elbv2.New(s)
-	provider.sts = sts.New(s,


This remove will make it easier for the V2 to be renamed in the coming PR.

Skarlso · 2022-03-29T15:09:55Z

Manual Test

2022-03-29 17:05:30 [ℹ]  node "ip-192-168-21-130.us-west-2.compute.internal" is ready
2022-03-29 17:05:31 [ℹ]  kubectl command should work with "/Users/skarlso/.kube/config", try 'kubectl get nodes'
2022-03-29 17:05:31 [✔]  EKS cluster "test-sts-refactor-1" in "us-west-2" region is ready
➜  simple-cluster
➜  simple-cluster k get nodes
NAME                                           STATUS   ROLES    AGE    VERSION
ip-192-168-21-130.us-west-2.compute.internal   Ready    <none>   114s   v1.21.5-eks-9017834

delete

2022-03-29 17:08:45 [ℹ]  waiting for CloudFormation stack "eksctl-test-sts-refactor-1-nodegroup-ng-1"
2022-03-29 17:09:02 [ℹ]  waiting for CloudFormation stack "eksctl-test-sts-refactor-1-nodegroup-ng-1"
2022-03-29 17:09:03 [ℹ]  will delete stack "eksctl-test-sts-refactor-1-cluster"
2022-03-29 17:09:04 [✔]  all cluster resources were deleted
➜  simple-cluster

Skarlso · 2022-03-29T15:44:59Z

.golangci.yml

@@ -1,5 +1,7 @@
 # options for analysis running
 run:
+  go: '1.18'


Apparently, this was needed for the ci to work properly.

…e presign call

pkg/eks/api.go

…r_sts

pkg/eks/apiv2.go

pkg/eks/generator.go

aclevername

LGTM 😁 ! Worth waiting for 3 reviewers IMO as its a bit complex. Also worth an integration test run? Or does the change not affect how we do our auth in CI?

Skarlso · 2022-03-30T14:53:36Z

Also worth an integration test run? Or does the change not affect how we do our auth in CI?

I ran a couple locally, it's basically like this... if it doesn't work on eksctl get cluster it basically will not work. :D If it does, it does, there is nothing else happening to the token that would make it not work on further calls. But I did run some tests to be sure that consecutive calls work. :) And that longer calls still work.

cPu1 · 2022-03-31T09:25:53Z

@Skarlso can you fix the conflicts before I start reviewing?

pkg/apis/eksctl.io/v1alpha5/types.go

Skarlso · 2022-03-31T10:43:21Z

@cPu1 done with the conflict. :)

pkg/eks/generator.go

pkg/eks/services_v2.go

…nticator for token generation (eksctl-io#5016) * Removing STS * Deleted the wrapper as it is no longer needed * Created an Interface for the Presign function * Extracted the generator and wrote a proper interface and mocks for the presign call * Postfilled a unit test * Added custom endpoint resolution * Put back the endpoint mapping malaka * Extract header function * Adjusted to review and removed whitelisted header

Skarlso added the kind/feature New feature or request label Mar 29, 2022

Skarlso commented Mar 29, 2022

View reviewed changes

Skarlso force-pushed the refactor_sts branch from efc3058 to b5edea6 Compare March 29, 2022 15:35

Skarlso changed the title ~~[WIP] Refactor sts~~ Remove dependency on STS v1 by removing the need to use aws-iam-authenticator for token generation Mar 29, 2022

Skarlso marked this pull request as ready for review March 29, 2022 15:37

Skarlso added 3 commits March 29, 2022 17:37

Removing STS

856abb8

Deleted the wrapper as it is no longer needed

0f85521

Created an Interface for the Presign function

b86fe48

Skarlso force-pushed the refactor_sts branch from b5edea6 to b86fe48 Compare March 29, 2022 15:37

Skarlso requested a review from a team March 29, 2022 15:39

Skarlso added area/tech-debt Leftover improvements in code, testing and building skip-release-notes Causes PR not to show in release notes and removed kind/feature New feature or request labels Mar 29, 2022

Skarlso commented Mar 29, 2022

View reviewed changes

Skarlso removed the request for review from a team March 30, 2022 06:59

Extracted the generator and wrote a proper interface and mocks for th…

6083b11

…e presign call

Skarlso requested review from a team and removed request for a team March 30, 2022 08:04

Skarlso commented Mar 30, 2022

View reviewed changes

pkg/eks/api.go Show resolved Hide resolved

Postfilled a unit test

a2421d3

Skarlso requested a review from a team March 30, 2022 08:30

Skarlso added 3 commits March 30, 2022 12:49

Merge branch 'main' into refactor_sts

d10c98f

Added custom endpoint resolution

b8004d6

Merge branch 'refactor_sts' of github.com:Skarlso/eksctl into refacto…

803d2a8

…r_sts

aclevername reviewed Mar 30, 2022

View reviewed changes

pkg/eks/apiv2.go Outdated Show resolved Hide resolved

aclevername reviewed Mar 30, 2022

View reviewed changes

pkg/eks/generator.go Outdated Show resolved Hide resolved

aclevername approved these changes Mar 30, 2022

View reviewed changes

Put back the endpoint mapping malaka

53f2718

Extract header function

ff336d3

Skarlso requested a review from a team March 30, 2022 15:20

Merge branch 'main' into refactor_sts

359b4cf

Skarlso commented Mar 31, 2022

View reviewed changes

pkg/apis/eksctl.io/v1alpha5/types.go Outdated Show resolved Hide resolved

Merge branch 'main' into refactor_sts

2c2816f

Skarlso force-pushed the refactor_sts branch from 92d0ad0 to 2c2816f Compare March 31, 2022 09:58

cPu1 reviewed Mar 31, 2022

View reviewed changes

pkg/eks/generator.go Outdated Show resolved Hide resolved

cPu1 reviewed Mar 31, 2022

View reviewed changes

pkg/eks/services_v2.go Outdated Show resolved Hide resolved

cPu1 reviewed Mar 31, 2022

View reviewed changes

pkg/eks/services_v2.go Outdated Show resolved Hide resolved

Skarlso added 2 commits March 31, 2022 17:16

Adjusted to review and removed whitelisted header

a5a802f

Merge branch 'main' into refactor_sts

27b1687

cPu1 approved these changes Apr 1, 2022

View reviewed changes

Skarlso added 4 commits April 1, 2022 12:45

Merge branch 'main' into refactor_sts

3580965

Merge branch 'main' into refactor_sts

4e364f4

Merge branch 'main' into refactor_sts

13777f0

Merge branch 'main' into refactor_sts

5c31cc2

Skarlso enabled auto-merge (squash) April 4, 2022 08:24

Skarlso merged commit e7de320 into eksctl-io:main Apr 4, 2022

hspencer77 mentioned this pull request Jul 8, 2022

Upgrade eksctl brave-intl/eksctl#44

Closed

7 tasks

Skarlso mentioned this pull request Jul 27, 2022

Any plans to support Go SDK v2? kubernetes-sigs/aws-iam-authenticator#444

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove dependency on STS v1 by removing the need to use aws-iam-authenticator for token generation #5016

Remove dependency on STS v1 by removing the need to use aws-iam-authenticator for token generation #5016

Skarlso commented Mar 29, 2022 •

edited

Loading

Skarlso Mar 29, 2022

Skarlso commented Mar 29, 2022

Skarlso Mar 29, 2022

aclevername left a comment

Skarlso commented Mar 30, 2022 •

edited

Loading

cPu1 commented Mar 31, 2022

Skarlso commented Mar 31, 2022

Remove dependency on STS v1 by removing the need to use aws-iam-authenticator for token generation #5016

Remove dependency on STS v1 by removing the need to use aws-iam-authenticator for token generation #5016

Conversation

Skarlso commented Mar 29, 2022 • edited Loading

Description

Checklist

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

Skarlso Mar 29, 2022

Choose a reason for hiding this comment

Skarlso commented Mar 29, 2022

Skarlso Mar 29, 2022

Choose a reason for hiding this comment

aclevername left a comment

Choose a reason for hiding this comment

Skarlso commented Mar 30, 2022 • edited Loading

cPu1 commented Mar 31, 2022

Skarlso commented Mar 31, 2022

Skarlso commented Mar 29, 2022 •

edited

Loading

Skarlso commented Mar 30, 2022 •

edited

Loading