Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing permission boundary from Karpetner iam resource #5024

Merged
merged 3 commits into from
Mar 31, 2022
Merged

Fix missing permission boundary from Karpetner iam resource #5024

merged 3 commits into from
Mar 31, 2022

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Mar 30, 2022

Description

Closes #4996

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@Skarlso Skarlso requested a review from a team March 30, 2022 10:13
@Skarlso Skarlso mentioned this pull request Mar 30, 2022
Closed
aclevername
aclevername approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@aclevername aclevername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😁 !

@Skarlso Skarlso requested a review from a team March 30, 2022 15:34
Himangini
Himangini approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@Skarlso Skarlso enabled auto-merge (squash) March 31, 2022 07:16
@Skarlso Skarlso merged commit d377e25 into eksctl-io:main Mar 31, 2022
@Skarlso Skarlso deleted the fix_karpenter_permission_boundary branch March 31, 2022 07:36
SlevinWasAlreadyTaken pushed a commit to SlevinWasAlreadyTaken/eksctl that referenced this pull request Apr 11, 2022
@Skarlso @SlevinWasAlreadyTaken
Fix missing permission boundary from Karpetner iam resource (eksctl-i…
05c4b29 
…o#5024)
@hspencer77 hspencer77 mentioned this pull request Jul 8, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Himangini Himangini Himangini approved these changes

@aclevername aclevername aclevername approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] KarpenterNodeRole creation fails due to missing permissions boundary
3 participants
@Skarlso @Himangini @aclevername