Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish slack notifications to aws-dev channel too #5072

Merged
merged 4 commits into from
Apr 6, 2022
Merged

Publish slack notifications to aws-dev channel too #5072

merged 4 commits into from
Apr 6, 2022

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Apr 5, 2022 •
edited
Loading

Description

Closes #5027

There is no activity on the PR, so I'm going to duplicate the slack action.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@Skarlso Skarlso added the skip-release-notes Causes PR not to show in release notes label Apr 5, 2022
Himangini
Himangini approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@Skarlso Skarlso merged commit 345a583 into eksctl-io:main Apr 6, 2022
SlevinWasAlreadyTaken pushed a commit to SlevinWasAlreadyTaken/eksctl that referenced this pull request Apr 11, 2022
@Skarlso @SlevinWasAlreadyTaken
Publish slack notifications to aws-dev channel too (eksctl-io#5072)
f638634 
* Publish slack notifications to aws-dev channel too

* Modified the text the include the released tag

* Added link and adjusted the team message
@hspencer77 hspencer77 mentioned this pull request Jul 8, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 cPu1 approved these changes

@Himangini Himangini Himangini approved these changes

@aclevername aclevername Awaiting requested review from aclevername

@nikimanoledaki nikimanoledaki Awaiting requested review from nikimanoledaki

Assignees
No one assigned
Labels
skip-release-notes Causes PR not to show in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Fix Slack notifications for releases
4 participants
@Skarlso @cPu1 @Himangini @aclevername