Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update migration document to include private nodegroups #5084

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Update migration document to include private nodegroups #5084

merged 1 commit into from
Apr 7, 2022

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Apr 7, 2022 •
edited
Loading

Description

Closes #5085

Update the migration document to include instructions for private nodegroups.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@Skarlso Skarlso added the kind/docs User documentation label Apr 7, 2022
@Skarlso
Copy link
Contributor Author

Skarlso commented Apr 7, 2022

@linschin Hi. :) Does that look correct? Is that what you did? Thanks!

@Skarlso Skarlso requested a review from a team April 7, 2022 07:30
@Skarlso Skarlso requested a review from cPu1 April 7, 2022 08:34
@cPu1 cPu1 merged commit 49f1648 into eksctl-io:main Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 cPu1 approved these changes

@aclevername aclevername aclevername approved these changes

Assignees
No one assigned
Labels
kind/docs User documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Doc] Update the migration announcement to include private nodegroups
3 participants
@Skarlso @cPu1 @aclevername