Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sorting in case the switch is off #5088

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Apr 7, 2022

Description

Don't sort in case the duplication suppression is not enabled.

Closes #5089

Incoming local crud test run result...

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@Skarlso Skarlso requested a review from a team April 7, 2022 14:09
Copy link
Contributor

@aclevername aclevername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it worth changing it so the sorting logic just mutates a local copy of the identities?

@Skarlso
Copy link
Contributor Author

Skarlso commented Apr 7, 2022

is it worth changing it so the sorting logic just mutates a local copy of the identities?

Thought about that. For now, it's fine, since, we don't really integration test that flag, and I don't really think we ever will because it's not worth the resource. So I decided to just leave it. It's a quicker and smaller fix, easier to review too instead of me adding a copy(dst, src) shenanigans. :)

@Skarlso
Copy link
Contributor Author

Skarlso commented Apr 7, 2022

Yay, all iamseriveaccount tests passed:

Ran 11 of 43 Specs in 1286.224 seconds
SUCCESS! -- 11 Passed | 0 Failed | 0 Pending | 32 Skipped
PASS | FOCUSED

@Skarlso Skarlso enabled auto-merge (squash) April 7, 2022 15:44
@Skarlso Skarlso merged commit 24d9aef into eksctl-io:main Apr 7, 2022
SlevinWasAlreadyTaken pushed a commit to SlevinWasAlreadyTaken/eksctl that referenced this pull request Apr 11, 2022
@hspencer77 hspencer77 mentioned this pull request Jul 8, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Don't sort iamserviceaccount groups if the no-duplicate-arns is false
3 participants