Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move AssignIpv6AddressOnCreation from task to template #5177

Merged

Conversation

nikimanoledaki
Copy link
Contributor

@nikimanoledaki nikimanoledaki commented Apr 26, 2022

Description

Closes #4363

This PR removes the workaround where we had a post-creation Task to enable AssignIpv6AddressOnCreation on public subnets. The issue was that it could not be set alongside MapPublicIpOnLaunch (which is only set for public subnets) due to a CF bug.

Instead, in this PR, this is done as part of the CF template.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@nikimanoledaki nikimanoledaki force-pushed the fix-assignipv6oncreation branch from dbe827b to 9241369 Compare April 26, 2022 10:21
@nikimanoledaki
Copy link
Contributor Author

Tested the IPv6 suite:

[0] Ran 1 of 1 Specs in 2080.985 seconds
[0] SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
[0] --- PASS: TestIPv6 (2080.99s)
[0] PASS

@nikimanoledaki nikimanoledaki marked this pull request as ready for review April 26, 2022 11:18
@nikimanoledaki nikimanoledaki requested a review from a team April 26, 2022 11:18
@Skarlso Skarlso requested a review from a team April 26, 2022 12:32
@nikimanoledaki nikimanoledaki merged commit 9edf0c1 into eksctl-io:main Apr 26, 2022
@hspencer77 hspencer77 mentioned this pull request Jul 8, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set AssignIpv6AddressOnCreation during template creation
3 participants