Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate release process #5369

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Automate release process #5369

merged 1 commit into from
Jun 3, 2022

Conversation

cPu1
Copy link
Contributor

@cPu1 cPu1 commented Jun 2, 2022

Description

This changelist automates the release process by removing the redundant steps of opening a PR against the release branch for bumping up the version.

Instead of generating Go code to set version.PreReleaseID, it's now passed via ldflags to go build. When the release candidate workflow is run, it gets the pre-release ID using nextPreReleaseID and passes it as an environment variable to goreleaser.

Closes #5317

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@cPu1 cPu1 added area/build-and-release skip-release-notes Causes PR not to show in release notes area/ci labels Jun 2, 2022
@cPu1 cPu1 force-pushed the automate-release branch from 447181b to 40e04ae Compare June 2, 2022 15:49
@cPu1 cPu1 requested a review from a team June 3, 2022 08:44
build/scripts/tag-common.sh Show resolved Hide resolved
@Skarlso Skarlso merged commit ef3505c into eksctl-io:main Jun 3, 2022
@cPu1 cPu1 mentioned this pull request Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-and-release area/ci skip-release-notes Causes PR not to show in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Automate release process and remove redundant manual steps
3 participants