Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vpc-cni to 1.12.6 #6692

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Update vpc-cni to 1.12.6 #6692

merged 1 commit into from
Jun 16, 2023

Conversation

wind0r
Copy link
Contributor

@wind0r wind0r commented Jun 14, 2023

Description

vpc-cni version 1.11 isnt supported for kubernetes 1.26.

see: https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html

Before you upgrade to Kubernetes 1.26, upgrade your Amazon VPC CNI plugin for Kubernetes to version 1.12 or later. If you don't upgrade to Kubernetes 1.26, earlier versions of the Amazon VPC CNI plugin for Kubernetes crash. For more information, see [Working with the Amazon VPC CNI plugin for Kubernetes for Kubernetes Amazon EKS add-on](https://docs.aws.amazon.com/eks/latest/userguide/managing-vpc-cni.html).

Also for 1.25 it is suggested to use v1.11.4+
See:
https://github.com/aws/amazon-vpc-cni-k8s#recommended-version

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@Himangini
Copy link
Collaborator

nice catch, we have broken workflow which i just noticed 😓, we'll fix it soon.

Copy link
Collaborator

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@Himangini Himangini changed the title chore: update vpc cni to be compatible with k8s >1.25 Update vpc-cni to 1.12.6 Jun 16, 2023
@Himangini Himangini merged commit d2d9faf into eksctl-io:main Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants