Update Bottlerocket image version on nodegroup upgrade #6923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TiberiuGC
added
kind/feature
cPu1
approved these changes
Aug 9, 2023
a-hilaly
approved these changes
Aug 9, 2023
Comment on lines
-160
to
-161
| }, | ||
| "Version": "1.27" |
There was a problem hiding this comment.
Was this necessary? If yes, i'm curious to hear why
There was a problem hiding this comment.
On nodegroup upgrades, there is a CFN limitation in which if you specify releaseVersion OR kubernetesVersion you can't update any other property, also you can't update both at the same time. Therefore, even if we run something like eksctl upgrade nodegroup --kubernetes-version 1.27, we'll still try to fetch the latest release version, and if one is found, we won't pass kubernetes version to CFN template.
This was previously required when upgrading kubernetes version as we weren't fetching release version for Bottlerocket.
cPu1
pushed a commit
to cPu1/eksctl
that referenced
this pull request
Aug 11, 2023
TiberiuGC
added a commit
to TiberiuGC/eksctl
that referenced
this pull request
Aug 24, 2023
idanshoham95
pushed a commit
to spotinst/weaveworks-eksctl
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR,
eksctl upgrade nodegroupcommand will fetch the latest image version for managed, eksctl created, Bottlerocket nodegroups and, if necessary, update it.Closes #6766
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯