Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release drafter] Treat RCs as full releases when drafting notes #7723

Merged

Conversation

TiberiuGC
Copy link
Collaborator

@TiberiuGC TiberiuGC commented Apr 24, 2024

Description

Release notes PR is currently displaying wrong release version when a RC that hasn't been yet graduated to full release exists. e.g. #7721

Manually tested the fix against my eksctl fork.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@TiberiuGC TiberiuGC force-pushed the improvement/include-pre-releases-in-drafter branch from 86328b4 to 9101574 Compare April 24, 2024 13:05
@TiberiuGC TiberiuGC marked this pull request as ready for review April 24, 2024 13:05
@TiberiuGC TiberiuGC changed the title [Release drafter] Consider RCs as being full releases when drafting notes [Release drafter] Treat RCs as being full releases when drafting notes Apr 24, 2024
@TiberiuGC TiberiuGC changed the title [Release drafter] Treat RCs as being full releases when drafting notes [Release drafter] Treat RCs as full releases when drafting notes Apr 24, 2024
@cPu1 cPu1 force-pushed the improvement/include-pre-releases-in-drafter branch from 9101574 to e80bb08 Compare April 25, 2024 08:48
@cPu1 cPu1 merged commit 2956a45 into eksctl-io:main Apr 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants