Ensure sequential task errors result in termination of all tasks #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is problematic as it results in confusing output message: [✖] waiting for CloudFormation stack "eksctl-beautiful-sheepdog-1560245255-cluster" to reach "CREATE_COMPLETE" status: ResourceNotReady: failed waiting for successful resource state [✖] invalid cluster config: missing CertificateAuthorityData [✖] failed to create cluster "beautiful-sheepdog-1560245255" The `missing CertificateAuthorityData` is very misleading.
errordeveloper
force-pushed
the
sequential-task-errors
branch
from
9b15ede to
6a9b7f7
Compare
martina-if
reviewed
Jun 11, 2019
| desc := task.Describe() | ||
| logger.Debug("started task: %s", desc) | ||
| errs := make(chan error) | ||
| if err := task.Do(errs); err != nil { | ||
| allErrs <- err | ||
| return | ||
| return false |
There was a problem hiding this comment.
Why not return an error instead?
There was a problem hiding this comment.
Because errors are handled via the channel already and we don't need to worry about the content as it's already take care of by the other mechanism, so this is just a hint, and boolean is easier to check.
martina-if
approved these changes
Jun 11, 2019
torredil
pushed a commit
to torredil/eksctl
that referenced
this pull request
May 20, 2022
add self as owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up from #865.
This is problematic as it results in confusing output message:
The
missing CertificateAuthorityDatais very misleading.Checklist
make build)make test)make integration-test)