Skip to content

Loosen dependencies #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2024
Merged

Loosen dependencies #4

merged 2 commits into from
Feb 17, 2024

Conversation

GarrettMooney
Copy link
Contributor

Duckdb has some really nice syntax updates that I wanted to utilize with this package so I loosened the dependencies.

Tests still pass.

Curious to hear what else you think this MR might need!

@ekzhang
Copy link
Owner

ekzhang commented Feb 17, 2024

Sounds good to me, I agree this should be loosened!

Just FYI though, the current duckdb~=0.5 version specifier is compatible with all versions of duckdb from 0.5 to <1.0. Right now the most recent version is duckdb 0.10.0. So this actually only affects pandas :)

@ekzhang ekzhang merged commit e3e86d0 into ekzhang:main Feb 17, 2024
@GarrettMooney
Copy link
Contributor Author

Sounds good to me, I agree this should be loosened!

Just FYI though, the current duckdb~=0.5 version specifier is compatible with all versions of duckdb from 0.5 to <1.0. Right now the most recent version is duckdb 0.10.0. So this actually only affects pandas :)

Good eye! Sounds like I was conflating things in a brittle environment I was working in 🤔 🤷 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants