-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sshx in CI/CD of public projects can have public logs #23
Comments
BTW, in this context:
|
Yes this is true, good catch. You need to disable public access to the logs of CI builds if you want to use sshx in a context like that. In practice the risk is quite low because it's an ephemeral app run, but it doesn't hurt to be safe with the usage recommendation. sshx disconnects if the machine disconnects. The session is garbage collected after a few minutes if the same client does not reconnect. |
ekzhang
changed the title
Placing sshx in CI/CD of open projects is insecure
sshx in CI/CD of public projects can have public logs
Nov 6, 2023
ekzhang
added a commit
that referenced
this issue
Nov 12, 2023
* Add warning about CI log visibility Resolves #23. * Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Great project!
But speaking of CI/CD, consider scenario:
printenv
shows all environment variables, including secrets (if any, of course)I'd add at least a warning about this in the README.
The text was updated successfully, but these errors were encountered: